Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/gdrive: port code to GdriveCore & add path_2_id cache #2203

Merged
merged 7 commits into from
May 9, 2023
Merged

services/gdrive: port code to GdriveCore & add path_2_id cache #2203

merged 7 commits into from
May 9, 2023

Conversation

Young-Flash
Copy link
Member

No description provided.

@Xuanwo Xuanwo changed the title port code to GdriveCore & add path_2_id cache services/gdrive: port code to GdriveCore & add path_2_id cache May 4, 2023
Xuanwo
Xuanwo reviewed May 4, 2023
View reviewed changes
core/src/services/gdrive/backend.rs Outdated Show resolved Hide resolved
core/src/services/gdrive/core.rs Outdated Show resolved Hide resolved
core/src/services/gdrive/core.rs Outdated Show resolved Hide resolved
core/src/services/gdrive/core.rs Outdated Show resolved Hide resolved
core/src/services/gdrive/core.rs Show resolved Hide resolved
core/src/services/gdrive/core.rs Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented May 4, 2023

Please update with main branch first to avoid possible conflicts.

@Young-Flash
Copy link
Member Author

I will fix them later cause I am going to swim now

@Xuanwo
Copy link
Member

Xuanwo commented May 4, 2023

I will fix them later cause I am going to swim now

Take your time and have fun!

@Xuanwo Xuanwo marked this pull request as draft May 4, 2023 09:03
@Young-Flash Young-Flash marked this pull request as ready for review May 5, 2023 12:12
Xuanwo
Xuanwo reviewed May 6, 2023
View reviewed changes
core/src/services/gdrive/core.rs Outdated Show resolved Hide resolved
core/src/services/gdrive/core.rs Outdated Show resolved Hide resolved
core/src/services/gdrive/core.rs Outdated Show resolved Hide resolved
core/src/services/gdrive/core.rs Outdated Show resolved Hide resolved
core/src/services/gdrive/core.rs Outdated Show resolved Hide resolved
core/src/services/gdrive/core.rs Outdated Show resolved Hide resolved
core/src/services/gdrive/core.rs Outdated Show resolved Hide resolved
core/src/services/gdrive/core.rs Show resolved Hide resolved
@Young-Flash Young-Flash requested review from Xuanwo and suyanhanx May 9, 2023 08:51
Xuanwo
Xuanwo approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit af273fa into apache:main May 9, 2023
@Xuanwo Xuanwo mentioned this pull request May 23, 2023
Merged
@Young-Flash Young-Flash deleted the gdrive branch June 19, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

@suyanhanx suyanhanx Awaiting requested review from suyanhanx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Young-Flash @Xuanwo @suyanhanx