The S3 file like writer in Python is not completing correctly.

[zzl221000]

The code is as follows.

import opendal

op = opendal.Operator('oss',...)
f = op.open('file.txt', 'wb')
f.write(b'0' * 1024 * 1024)
f.close()

Created a Multipart, but the close method did not complete the Multipart.

[Xuanwo]

Hi, would like to share more details about this? Did it raise an error?

[zzl221000]

Hi, would like to share more details about this? Did it raise an error?

@Xuanwo The program ends without any exceptions.

Process finished with exit code 0

Moreover, when the write method is called only once, not even a Multipart is created; it just writes to the memory.

[Xuanwo]

Moreover, when the write method is called only once, not even a Multipart is created; it just writes to the memory.

First, if the write function is only called once, we will optimize it by avoiding multipart upload to minimize API calls. Additionally, opendal requires calling close to ensure that all data has been flushed.

[zzl221000]

@Xuanwo
I called the close method. f.close()

[Xuanwo]

Ok, I got it. It does a bug in our opendal binding. We missed to call close for the file internally.

[Xuanwo]

We can fix it by calling close in inner.close() and __exit__. @zzl221000 would you like to help fix this?

[zzl221000]

@Xuanwo I tried to fix it, but my autoformatter had some issues, leading to additional commits.

[Xuanwo]

@Xuanwo I tried to fix it, but my autoformatter had some issues, leading to additional commits.

Thanks!