Skip to content

Commit

Permalink
fix tests for Ceph RADOS and fix complete.rs
Browse files Browse the repository at this point in the history
  • Loading branch information
meteorgan committed Jan 20, 2025
1 parent 6c452d4 commit ddc3de5
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
6 changes: 4 additions & 2 deletions core/src/layers/complete.rs
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,8 @@ where
Error::new(ErrorKind::Unexpected, "writer has been closed or aborted")
})?;

// we must return `Err` before setting inner to None; otherwise,
// we won't be able to retry `close` in `RetryLayer`.
let ret = w.close().await?;
self.inner = None;

Expand Down Expand Up @@ -557,9 +559,9 @@ where
Error::new(ErrorKind::Unexpected, "writer has been closed or aborted")
})?;

let ret = w.close();
let ret = w.close()?;
self.inner = None;

ret
Ok(ret)
}
}
7 changes: 6 additions & 1 deletion core/tests/behavior/async_write.rs
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,12 @@ pub async fn test_writer_return_metadata(op: Operator) -> Result<()> {
);
}
if let Some(etag) = meta.etag() {
assert_eq!(stat_meta.etag().expect("etag must exist"), etag);
// workaround for Ceph RADOS Gateway
let mut etag = etag.to_string();
if !etag.starts_with("\"") {
etag = format!("\"{}\"", etag);
}
assert_eq!(stat_meta.etag().expect("etag must exist"), &etag);
}
if let Some(version) = meta.version() {
assert_eq!(stat_meta.version().expect("version must exist"), version);
Expand Down

0 comments on commit ddc3de5

Please sign in to comment.