Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14275 Fix quoting configuration handling in UpdateDatabaseTable during ALTER #9727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sfc-gh-mgemra
Copy link
Contributor

@sfc-gh-mgemra sfc-gh-mgemra commented Feb 18, 2025

Summary

NIFI-14275

The decision about quoting column names during ALTER TABLE in the UpdateDatabaseTable processor was moved to database dialect services, causing inconsistency in behavior. This logic should remain part of the UpdateDatabaseTable processor, where users can explicitly choose whether to quote table and column names via the QUOTE_COLUMN_IDENTIFIERS and QUOTE_TABLE_IDENTIFIER properties.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@sfc-gh-mgemra sfc-gh-mgemra force-pushed the NIFI-14275-respect-quoting-configuration-in-update-database-table branch from 1e5a831 to 3a4f166 Compare February 18, 2025 16:13
@sfc-gh-mgemra sfc-gh-mgemra marked this pull request as ready for review February 18, 2025 17:38
@sfc-gh-mgemra sfc-gh-mgemra force-pushed the NIFI-14275-respect-quoting-configuration-in-update-database-table branch from 3a4f166 to 95c7ae1 Compare February 18, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant