NIFI-14213 Fixed for Inherited Parameter Context Not Retained When Up… #9714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grading Process Group Version
|
@pvillard31 I have updated the PR for version 2.0. Could you please review it? |
pvillard31
requested changes
Feb 12, 2025
...c/main/java/org/apache/nifi/flow/synchronization/StandardVersionedComponentSynchronizer.java
Outdated
Show resolved
Hide resolved
|
@pvillard31, I have updated the CheckStyle fix. Could you please review it? |
|
Hi @pvillard31 any update ? |
pvillard31
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
The change makes sense as we could very well have version 1 with 1 inherited parameter context, and version 2 with 2 inherited parameter contexts. Tested the change following the steps described in the JIRA. I'm a +1, merging. Thanks @2020555642rahul.
|
Forgot to amend the commit to add the magic words... closing manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where inherited parameter contexts were not properly attached when upgrading a versioned process group. Previously, upgrading a flow would create the new inherited parameter context but fail to link it to the parameter context, causing missing parameter references. This fix ensures that inherited parameter contexts are correctly retained and updated during flow upgrades.
Issue link: https://issues.apache.org/jira/browse/NIFI-14213