NIFI-14153 Applied PMD's SimplifiableTestAssertion across the code base and fixed the violations.

[dan-s1]

Summary

NIFI-14153

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 21

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[dan-s1]

@exceptionfactory Can you please give me insight as to whether the system tests are failing due to some of the changes I made? I am not finding I made actual changes to the integration tests that are failing. Please advise. Thanks!

On Ubuntu Java 21 there are many errors similar to
ITDeleteS3Object.testDeleteFolder:57 Could not invoke methods annotated with @OnScheduled annotation due to: java.lang.reflect.InvocationTargetException. I didn't change ITDeleteS3Object

[exceptionfactory]

The system test failures are related to a recent commit for #9638.

[dan-s1]

I do not understand as they passed there though.

[pvillard31]

This is because those tests were not triggered on the other PR due to the limited scope of the changes. I'm addressing this.

[dan-s1]

I assume though even with the changes in #9642 changes still must be made to account for the commit in #9638.

[pvillard31]

I believe Mark is working on a fix to complete the merged PR and get all the builds green.

[pvillard31]

@dan-s1 - it should be ok now if you rebase against main

[exceptionfactory]

Thanks @dan-s1, this is a helpful improvement for keeping test assertions clear and consistent! +1 merging