-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-13798: Update Airtable docs with PATs due to API Keys deprecation #9308
Conversation
Reviewing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lehel44 Thanks for updating the Airtable processor with the new authentication method!
Please note, the processor cannot work with the default API URL
property value: https://api.airtable.com/v0
. Ending /
needs to be added manually. Most probably it is due to the HTTP client implementation change in StandardWebClientServiceProvider
(NIFI-13619). It may affect other processors using this controller service too.
...irtable-processors/src/main/java/org/apache/nifi/processors/airtable/QueryAirtableTable.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review changes!
I checked the ending /
issue and it is kind of a regression and a general bug affecting other components too. It should be fixed in StandardHttpUriBuilder
. Filed NIFI-13810. Let's wait for that being merged and then it is not needed to fix the /
handling locally.
...irtable-processors/src/main/java/org/apache/nifi/processors/airtable/QueryAirtableTable.java
Show resolved
Hide resolved
1a25bba
to
a832742
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review changes @Lehel44!
+1 merging
Summary
NIFI-13798
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation