Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13798: Update Airtable docs with PATs due to API Keys deprecation #9308

Closed
wants to merge 4 commits into from

Conversation

Lehel44
Copy link
Contributor

@Lehel44 Lehel44 commented Sep 24, 2024

Summary

NIFI-13798

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@turcsanyip turcsanyip self-requested a review September 24, 2024 16:09
@turcsanyip
Copy link
Contributor

Reviewing...

Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lehel44 Thanks for updating the Airtable processor with the new authentication method!

Please note, the processor cannot work with the default API URL property value: https://api.airtable.com/v0. Ending / needs to be added manually. Most probably it is due to the HTTP client implementation change in StandardWebClientServiceProvider (NIFI-13619). It may affect other processors using this controller service too.

Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review changes!

I checked the ending / issue and it is kind of a regression and a general bug affecting other components too. It should be fixed in StandardHttpUriBuilder. Filed NIFI-13810. Let's wait for that being merged and then it is not needed to fix the / handling locally.

@Lehel44 Lehel44 force-pushed the NIFI-13798 branch 3 times, most recently from 1a25bba to a832742 Compare October 1, 2024 21:30
Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review changes @Lehel44!

+1 merging

@asfgit asfgit closed this in 8424e34 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants