solves #7044, refactor inner to outer for record #8197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see issue apache#7044 for exact problem. Start with adding tests. Introduced RECORD and RECORD_COMPONENT case labels in multiple places. Deal with method params for the record header in InnerOuterTransformer. The given way of printing the 'method parameters' for the record header include 'private final', producing illegal java code. The solution found might not be the moset elegant, but since the tree modifications will not persist into any real source code, it is acceptable. The solution strips `private` and `final` from the VARIABLE trees. Delete file threw and unnecessary exception where a simple null test suffices.
mbien
added
Java
mbien
reviewed
Jan 26, 2025
...ring.java/test/unit/src/org/netbeans/modules/refactoring/java/test/InnerOuterRecordTest.java
Outdated
Show resolved
Hide resolved
java/java.source.base/src/org/netbeans/modules/java/source/base/SourceLevelUtils.java
Outdated
Show resolved
Hide resolved
...oring.java/test/unit/src/org/netbeans/modules/refactoring/java/test/RefactoringTestBase.java
Outdated
Show resolved
Hide resolved
...oring.java/test/unit/src/org/netbeans/modules/refactoring/java/test/RefactoringTestBase.java
Outdated
Show resolved
Hide resolved
...oring.java/test/unit/src/org/netbeans/modules/refactoring/java/test/RefactoringTestBase.java
Outdated
Show resolved
Hide resolved
...actoring.java/src/org/netbeans/modules/refactoring/java/plugins/InnerToOuterTransformer.java
Outdated
Show resolved
Hide resolved
java/java.source.base/src/org/netbeans/api/java/source/TreePathHandle.java
Show resolved
Hide resolved
java/java.source.base/src/org/netbeans/modules/java/source/pretty/VeryPretty.java
Outdated
Show resolved
Hide resolved
java/java.source.base/src/org/netbeans/modules/java/source/pretty/VeryPretty.java
Show resolved
Hide resolved
...va.source.base/test/unit/src/org/netbeans/modules/java/source/save/RecordFormattingTest.java
Outdated
Show resolved
Hide resolved
mbien
reviewed
Jan 26, 2025
java/java.source.base/src/org/netbeans/api/java/source/ElementHandle.java
Outdated
Show resolved
Hide resolved
...oring.java/test/unit/src/org/netbeans/modules/refactoring/java/test/RefactoringTestBase.java
Show resolved
Hide resolved
.../refactoring.java/src/org/netbeans/modules/refactoring/java/api/InnerToOuterRefactoring.java
Outdated
Show resolved
Hide resolved
|
Dear mbien, thank you for your time. I just pushed to branch issue7044 on my fork. |
mbien
reviewed
Jan 30, 2025
There was a problem hiding this comment.
I just pushed to branch issue7044 on my fork.
Is there anything I need to do?
thats all you have to do. Its an iterative process. The very last step before merge would be to squash as final touch - but that is for later.
Tests ran are green too - awesome. Left a few more comments.
java/java.source.base/src/org/netbeans/modules/java/source/base/SourceLevelUtils.java
Outdated
Show resolved
Hide resolved
...ring.java/test/unit/src/org/netbeans/modules/refactoring/java/test/InnerOuterRecordTest.java
Outdated
Show resolved
Hide resolved
...oring.java/test/unit/src/org/netbeans/modules/refactoring/java/test/RefactoringTestBase.java
Show resolved
Hide resolved
...oring.java/test/unit/src/org/netbeans/modules/refactoring/java/test/RefactoringTestBase.java
Show resolved
Hide resolved
mbien
reviewed
Jan 30, 2025
java/refactoring.java/src/org/netbeans/modules/refactoring/java/plugins/DeleteFile.java
Outdated
Show resolved
Hide resolved
mbien
reviewed
Jan 30, 2025
...actoring.java/src/org/netbeans/modules/refactoring/java/plugins/InnerToOuterTransformer.java
Outdated
Show resolved
Hide resolved
|
removed lines as per |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #7044 for exact problem.
Start with adding tests.
Introduced RECORD and RECORD_COMPONENT case labels in multiple places.
Deal with method params for the record header in InnerOuterTransformer. The given way of printing the 'method parameters' for the record header include 'private final', producing illegal java code. The solution found might not be the moset elegant, but since the tree modifications will not persist into any real source code, it is acceptable. The solution strips
privateandfinalfrom the VARIABLE trees.Delete file threw and unnecessary exception where a simple null test
suffices.
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.