This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Squeeze op #9700
Merged
Squeeze op #9700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about unsqeeze? |
|
@chinakook |
piiswrong
reviewed
Feb 6, 2018
src/operator/tensor/matrix_op.cc
Outdated
| }) | ||
| .set_attr<nnvm::FInferShape>("FInferShape", SqueezeShape) | ||
| .set_attr<nnvm::FInferType>("FInferType", ElemwiseType<1, 1>) | ||
| .set_attr<FCompute>("FCompute<cpu>", SqueezeCompute<cpu>) |
There was a problem hiding this comment.
I think you can use IdentityCompute directly?
There was a problem hiding this comment.
You are right. Changed now. Thanks.
|
@reminisce could you add a fluent entry for this in both nd and sym? |
|
@szha Oh, yes. I forgot to do so. I will submit a PR to add the fluent entry for this op. |
|
@reminisce yes, It's equalevant. |
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* Add squeeze op * Add unit test * Fix lint * User IdentityCompute directly
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* Add squeeze op * Add unit test * Fix lint * User IdentityCompute directly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implemented squeeze op in MXNet as numpy.squeeze. Requested by @szha .
https://docs.scipy.org/doc/numpy/reference/generated/numpy.squeeze.html
@eric-haibin-lin
Checklist
Essentials
make lint)