Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Reverting namespace change #9579

Merged
merged 1 commit into from
Jan 27, 2018
Merged

Reverting namespace change #9579

merged 1 commit into from
Jan 27, 2018

Conversation

nswamy
Copy link
Member

@nswamy nswamy commented Jan 26, 2018

Reverting namespace change since it breaks backward compatibility and needs a major version bump up.

Revert "Refactor scala code/tests/examples/docs to use org.apache.mxnet (#9324)"

This reverts commit deb25bc.

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

…d breaks backward compatibility.

Revert "Refactor scala code/tests/examples/docs to use org.apache.mxnet (apache#9324)"

This reverts commit deb25bc.
@nswamy nswamy requested review from szha and yzhliu as code owners January 26, 2018 22:08
@marcoabreu
Copy link
Contributor

@srochel

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait for @yzhliu's comment.

@yzhliu yzhliu merged commit 671df77 into apache:master Jan 27, 2018
@yzhliu
Copy link
Member

yzhliu commented Jan 27, 2018

Thanks @nswamy

rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
…d breaks backward compatibility. (apache#9579)

Revert "Refactor scala code/tests/examples/docs to use org.apache.mxnet (apache#9324)"

This reverts commit deb25bc.
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
…d breaks backward compatibility. (apache#9579)

Revert "Refactor scala code/tests/examples/docs to use org.apache.mxnet (apache#9324)"

This reverts commit deb25bc.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants