This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[Master] The size of a stack needs to be greater than 4 #20581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The size of a stack is always 4. A new optional (#658) structure is used to indicate that an object t may be "moved from" ~ allowing the efficient transfer of resources from t to another object. If an old value is moved into a new object, then the size is not enough and a blind value is reading out of the memory ~ hence: a double corruption error shows up. The size of the stack needs to be greater to avoid double corruption errors. The issue comes from #20560.
In this scenario: if a previous container is moved into a new buffer, then an address of a buffer is the same.
Checklist
Essentials
Changes
Comments