Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Revise MKLDNN Builds on Arm and Add a CMake Template for Arm #20266

Merged
merged 3 commits into from
May 14, 2021
Merged

[v1.x] Revise MKLDNN Builds on Arm and Add a CMake Template for Arm #20266

merged 3 commits into from
May 14, 2021

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented May 13, 2021

clean up the mkldnn builds with acl and apl.
also add a cmake template for arm users

@Zha0q1 Zha0q1 requested a review from szha as a code owner May 13, 2021 01:26
@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, centos-gpu, sanity, unix-gpu, unix-cpu, clang, windows-gpu, website, miscellaneous, edge, windows-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels May 13, 2021
mseth10
mseth10 reviewed May 13, 2021
View reviewed changes
config/linux_arm.cmake Outdated Show resolved Hide resolved
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels May 13, 2021
mseth10
mseth10 approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels May 14, 2021
@Zha0q1 Zha0q1 requested a review from aaronmarkham as a code owner May 14, 2021 03:33
@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 14, 2021
@Zha0q1 Zha0q1 merged commit 9eae0a2 into apache:v1.x May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu left review comments

@mseth10 mseth10 mseth10 approved these changes

@josephevans josephevans josephevans approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zha0q1 @mxnet-bot @leezu @josephevans @mseth10