Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[REFACTOR] Refactor test_quantize.py to use Gluon API #20227

Merged
merged 4 commits into from
Jun 17, 2021
Merged

[REFACTOR] Refactor test_quantize.py to use Gluon API #20227

merged 4 commits into from
Jun 17, 2021

Conversation

bgawrych
Copy link
Contributor

Description

Refactor tests/python/quantization/test_quantization.py file to uutilize Gluon API instead of symbolic.
I'm enabling also flaky test for mkldnn test_quantized_conv as it seems to work correctly now

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage

@mxnet-bot
Copy link

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, windows-gpu, unix-cpu, unix-gpu, sanity, clang, windows-cpu, website, centos-gpu, edge, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 29, 2021
@szha szha requested a review from akarbown April 29, 2021 17:34
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [centos-cpu, unix-gpu, windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu, windows-cpu, centos-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 30, 2021
bartekkuncer
bartekkuncer reviewed May 25, 2021
View reviewed changes
tests/python/quantization/test_quantization.py Outdated Show resolved Hide resolved
tests/python/quantization/test_quantization.py Outdated Show resolved Hide resolved
tests/python/quantization/test_quantization.py Outdated Show resolved Hide resolved
tests/python/quantization/test_quantization.py Outdated Show resolved Hide resolved
tests/python/quantization/test_quantization.py Show resolved Hide resolved
tests/python/quantization/test_quantization.py Show resolved Hide resolved
tests/python/quantization/test_quantization.py Outdated Show resolved Hide resolved
tests/python/quantization/test_quantization.py Outdated Show resolved Hide resolved
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 25, 2021
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu, unix-cpu, windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, unix-cpu, windows-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 26, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 26, 2021
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu, unix-cpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, unix-cpu, windows-gpu]

@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label May 27, 2021
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 27, 2021
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 31, 2021
@bgawrych
Copy link
Contributor Author

bgawrych commented Jun 1, 2021

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 1, 2021
@bgawrych bgawrych mentioned this pull request Jun 1, 2021
Merged
3 tasks
@bgawrych bgawrych force-pushed the refactor_test_quantize branch from c0b9cdf to d9681b7 Compare June 9, 2021 10:59
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 9, 2021
@akarbown akarbown merged commit b54b7f3 into apache:master Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akarbown akarbown akarbown approved these changes

@bartekkuncer bartekkuncer bartekkuncer approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bgawrych @mxnet-bot @bartekkuncer @akarbown @mseth10