This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D #20107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @PawelGlomski-Intel , Thanks for submitting the PR
CI supported jobs: [windows-cpu, unix-gpu, website, unix-cpu, miscellaneous, sanity, edge, clang, windows-gpu, centos-gpu, centos-cpu] Note: |
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
|
@mxnet-bot run ci [unix-cpu, website] |
|
Jenkins CI successfully triggered : [website, unix-cpu] |
lanking520
added
pr-awaiting-testing
szha
reviewed
Apr 3, 2021
PawelGlomski-Intel
force-pushed
the
pglo/deconvFix
branch
from
27eb164 to
cab1562
Compare
lanking520
added
pr-awaiting-testing
|
@mxnet-bot run ci [unix-gpu, centos-gpu] |
|
Jenkins CI successfully triggered : [centos-gpu, unix-gpu] |
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
mseth10
added
pr-awaiting-testing
|
Merged. @PawelGlomski-Intel thank you! |
PawelGlomski-Intel
added a commit
to PawelGlomski-Intel/incubator-mxnet
that referenced
this pull request
May 21, 2021
…tion 2D (apache#20107) * Use mkldnn deconvolution primitive in deconvolution * Apply clang-format * Refactor deconvolution version 1 * Refactor deconvolution version 2 and use permute_axes in IOLogicalSwapDesc * Refactor deconvolution version 3 * Enable Deconvolution2D test * Fix sanity * Fix windows builds * Fix deconvolution with bias test
9 tasks
PawelGlomski-Intel
added a commit
to PawelGlomski-Intel/incubator-mxnet
that referenced
this pull request
Aug 31, 2021
…tion 2D (apache#20107) * Use mkldnn deconvolution primitive in deconvolution * Apply clang-format * Refactor deconvolution version 1 * Refactor deconvolution version 2 and use permute_axes in IOLogicalSwapDesc * Refactor deconvolution version 3 * Enable Deconvolution2D test * Fix sanity * Fix windows builds * Fix deconvolution with bias test
PawelGlomski-Intel
added a commit
to PawelGlomski-Intel/incubator-mxnet
that referenced
this pull request
Sep 20, 2021
…tion 2D (apache#20107) * Use mkldnn deconvolution primitive in deconvolution * Apply clang-format * Refactor deconvolution version 1 * Refactor deconvolution version 2 and use permute_axes in IOLogicalSwapDesc * Refactor deconvolution version 3 * Enable Deconvolution2D test * Fix sanity * Fix windows builds * Fix deconvolution with bias test
PawelGlomski-Intel
added a commit
to PawelGlomski-Intel/incubator-mxnet
that referenced
this pull request
Sep 22, 2021
…tion 2D (apache#20107) * Use mkldnn deconvolution primitive in deconvolution * Apply clang-format * Refactor deconvolution version 1 * Refactor deconvolution version 2 and use permute_axes in IOLogicalSwapDesc * Refactor deconvolution version 3 * Enable Deconvolution2D test * Fix sanity * Fix windows builds * Fix deconvolution with bias test
szha
pushed a commit
that referenced
this pull request
Sep 29, 2021
…t and fix bias (#20292) * [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D (#20107) * Use mkldnn deconvolution primitive in deconvolution * Apply clang-format * Refactor deconvolution version 1 * Refactor deconvolution version 2 and use permute_axes in IOLogicalSwapDesc * Refactor deconvolution version 3 * Enable Deconvolution2D test * Fix sanity * Fix windows builds * Fix deconvolution with bias test * [v1.x][FEATURE] Add MKLDNN Deconvolution 1D and 3D support (#20137) * Use MXNET_USE_ONEDNN * Fix test * Apply formatter * Add native support for 3D deconvolution * Remove outdated check * Replace math.prod with np.prod * Check convolution layout only when it has value * Remove outdated check * Change tests * Increase default workspace size to mach convolution * Fix deconv workspace size * Increase default deconv workspace size in python API * Disable 3D tests for GPU * Add deconv arguments checks * Remove next_impl calls until it is fixed * Share workspace * Fix documentation * Add test_deconv_dilation * Fix check * Fix include order
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, deconvolution 2D is implemented with oneDNN convolution primitives. Deconvolution forward pass is implemented with convolution backward primitives that do not include bias. This requires you to manually add the bias, which is currently broken (#19768).
This change implements oneDNN deconvolution primitives to deconvolution, fixing (#19768).
As I couldn't reproduce (#12579) for the 2D case, I enabled the 2D part of this test.
Checklist
Essentials
Changes