Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[wip] [v1.x] Onnx export support for slicechannel and box_nms #19846

Merged
merged 7 commits into from
Feb 6, 2021
Merged

[wip] [v1.x] Onnx export support for slicechannel and box_nms #19846

merged 7 commits into from
Feb 6, 2021

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Feb 4, 2021 •
edited
Loading

add full support fir skucechannel. Unblocked id_index!=-1 case for box_nms. The behavior will not be the same as mxnet but a warning is added to notify the user of this

@Zha0q1 Zha0q1 requested a review from szha as a code owner February 4, 2021 23:58
@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, centos-gpu, unix-cpu, edge, sanity, centos-cpu, windows-gpu, unix-gpu, miscellaneous, website, windows-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@Zha0q1 Zha0q1 changed the title [v1.x] Onnx export support for slicechannel and box_nms [wip] [v1.x] Onnx export support for slicechannel and box_nms Feb 4, 2021
@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Feb 4, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 5, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Feb 5, 2021
waytrue17
waytrue17 approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

josephevans
josephevans approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small concern noted, but LGTM!

tests/python-pytest/onnx/test_operators.py Outdated
@pytest.mark.parametrize('dtype', ['float16', 'float32'])
@pytest.mark.parametrize('num_outputs', [1, 3, 9])
@pytest.mark.parametrize('axis', [1, 2, -1, -2])
@pytest.mark.parametrize('squeeze_axis', [True, False])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a numerical value to squeeze_axis? Does the onnx export function correctly see 'True' when passed a 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added '1' as an equivalent to 'True', but I think technically users can also use other values such as 4, 123, although i doubt they would actually use it that way

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 5, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 5, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 5, 2021
@Zha0q1 Zha0q1 merged commit da887f1 into apache:v1.x Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@waytrue17 waytrue17 waytrue17 approved these changes

@josephevans josephevans josephevans approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zha0q1 @mxnet-bot @josephevans @waytrue17 @lanking520