This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x] Add onnx export support for where and greater_scalar operators. #19745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @josephevans , Thanks for submitting the PR
CI supported jobs: [windows-cpu, edge, unix-cpu, unix-gpu, sanity, centos-cpu, clang, centos-gpu, windows-gpu, miscellaneous, website] Note: |
lanking520
added
the
pr-awaiting-testing
Zha0q1
approved these changes
Jan 12, 2021
| @@ -378,3 +378,27 @@ def test_onnx_export_contrib_BilinearResize2D(tmp_path, dtype, params): | |||
| x = mx.nd.arange(0, 160).reshape((2, 2, 5, 8)) | |||
| M = def_model('contrib.BilinearResize2D', **params) | |||
| op_export_test('contrib_BilinearResize2D', M, [x], tmp_path) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("dtype", ["float32", "float64", "int32", "int64"]) | |||
There was a problem hiding this comment.
Update to work with float16 and also test it :) Thanks for the help.
lanking520
added
pr-work-in-progress
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
lanking520
added
pr-work-in-progress
added 2 commits
January 13, 2021 17:19
lanking520
added
pr-awaiting-testing
lanking520
added
pr-work-in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add onnx export support and unit tests for the "where" and "greater_scalar" operators.