Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Add more ONNX export operator support #19727

Merged
merged 13 commits into from
Jan 6, 2021
Merged

[v1.x] Add more ONNX export operator support #19727

merged 13 commits into from
Jan 6, 2021

Conversation

josephevans
Copy link
Contributor

Description

Adds ONNX export support for:

  • ones_like
  • arange

Clean up export functions for pad, dropout, clip and topk.

@josephevans josephevans requested a review from szha as a code owner January 6, 2021 00:11
@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, website, edge, unix-gpu, miscellaneous, centos-cpu, centos-gpu, windows-cpu, clang, sanity, windows-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 6, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 6, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jan 6, 2021
@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 6, 2021
Zha0q1
Zha0q1 approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

waytrue17
waytrue17 approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@Zha0q1 Zha0q1 merged commit c9f111f into apache:v1.x Jan 6, 2021
@josephevans josephevans deleted the onnx_fixes_round5_v1.x branch January 6, 2021 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@waytrue17 waytrue17 waytrue17 approved these changes

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josephevans @mxnet-bot @Zha0q1 @waytrue17 @lanking520