This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[BUGFIX] [1.x] Backport of "Avoid logging seed for skipped tests #19322" #19327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes issue #19255, where it was noted that when a unittest was skipped, the skip-exception caused the with_seed() decorator to log the seed. While the 1.x branch uses nosetests, not pytest, the same behavior is seen on 1.x. With this PR the seed is no longer logged.
This PR doesn't have any testing added- I will inspect the CI log for skipped tests such as test_operator.py:test_activation to verify that the seed logging has been successfully eliminated.
@leezu @samskalicky
Checklist
Essentials