-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[v1.x][submodule] Upgrade to oneDNN v1.6 #18822
Conversation
Hey @bartekkuncer , Thanks for submitting the PR
CI supported jobs: [edge, windows-gpu, unix-cpu, clang, centos-cpu, centos-gpu, miscellaneous, unix-gpu, sanity, website, windows-cpu] Note: |
Thanks @bartekkuncer
|
@bartekkuncer we may add the new mkldnn format in the file :) |
@ChaiBapchya @pengzhao-intel all tests are passing now. |
@bartekkuncer let's update the library to the formal release: https://github.com/oneapi-src/oneDNN/releases/tag/v1.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
@mxnet-label-bot add [pr-awaiting-merge] |
@szha Thanks for the merge |
New PR with update to official 1.6 oneDNN release: #18867. |
and v1.7.x too? |
@bartekkuncer @ChaiBapchya No, we cannot upgrade v1.6.x to the new release. Currently MXNet v1.6.x is using a version has LSTMP INT8 which is not present in oneDNN v1.6. @samskalicky Yes, we can upgrade it to v1.7.x if needed. And yes, we will add it to the scope of v1.8 release. |
I was only suggesting we do 1.7 if we were gonna do 1.6. But if not we can just do 1.8 |
@TaoLv which version of oneDNN will have both those fixes?
|
@ChaiBapchya v1.7 of oneDNN is supposed to have both these fixes |
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments