[v1.x] Cherry-pick #17776 #17681 #18465
Conversation
* Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy Fixes a regression in CD introduced by apache#17645 * Fix whitespace * Add NATIVE_ADDITIONAL.md Fixes a regression in CD introduced by apache#16899 * Update other $TYPE_ADDITIONAL.MD * Fix cd/python/docker Fixes regression introduced by apache#15990
* update pypi description, setup.py, use manylinux2010, use unified dist link for nightly * Use manylinux2014 Co-authored-by: Leonard Lausen <[email protected]>
|
Hey @mseth10 , Thanks for submitting the PR
CI supported jobs: [website, centos-gpu, miscellaneous, centos-cpu, windows-gpu, unix-gpu, clang, windows-cpu, sanity, unix-cpu, edge] Note: |
| @@ -24,7 +24,7 @@ | |||
|
|
|||
| // NOTE: the following variables are referenced in the mxnet_lib_pipeline jenkins file imported bellow | |||
| // libmxnet location | |||
| libmxnet = 'lib/libmxnet.so' | |||
There was a problem hiding this comment.
Thank you Manu. As with the 1.7 PR: Changing this line is done when switching to cmake build on CD. I don't think it's done yet (but we certainly want to do it at some point to decrease the infrastructure code divergence between 1.x and master branch)
So I suggest to remove this line in the PR and have a separate PR for the build change later
There was a problem hiding this comment.
I reverted this line. Rest of the code changes look good?
|
Did you look at the docker build pipeline in more detail? From the last time I checked it, I believe the pipeline always publishes to a "latest" tag. Running the pipeline as is on both the master and 1.x branch would thus lead to a race condition and it'd be unclear if the 1.x or master version of the image is published. Besides the technical issue, I'm currently not sure about the legal status of the pipeline. But that can be discussed in a separate issue. |
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
|
@leezu please merge. |
|
Ping @TaoLv , @pengzhao-intel to help merge :) |
* Fix CD (apache#17776) * Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy Fixes a regression in CD introduced by apache#17645 * Fix whitespace * Add NATIVE_ADDITIONAL.md Fixes a regression in CD introduced by apache#16899 * Update other $TYPE_ADDITIONAL.MD * Fix cd/python/docker Fixes regression introduced by apache#15990 * [CD] update pypi description, setup.py (apache#17681) * update pypi description, setup.py, use manylinux2010, use unified dist link for nightly * Use manylinux2014 Co-authored-by: Leonard Lausen <[email protected]> * reverting .so path as per MAKE flow Co-authored-by: Leonard Lausen <[email protected]> Co-authored-by: Sheng Zha <[email protected]> Co-authored-by: Leonard Lausen <[email protected]>
Description
Cherry-pick #17776 #17681 to update PyPI description
This fixes #18462