Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] add: numpy op trilindices #17904

Merged
merged 1 commit into from
Apr 10, 2020
Merged

[Numpy] add: numpy op trilindices #17904

merged 1 commit into from
Apr 10, 2020

Conversation

yijunc
Copy link
Contributor

@yijunc yijunc commented Mar 25, 2020

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@yijunc yijunc requested a review from szha as a code owner March 25, 2020 07:02
@mxnet-bot
Copy link

Hey @BenjaminCHEN2016 , Thanks for submitting the PR
Once your PR is ready for CI checks, invoke the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, website, unix-gpu, edge, centos-cpu, windows-cpu, miscellaneous, sanity, unix-cpu, centos-gpu, clang]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@haojin2 haojin2 self-assigned this Mar 25, 2020
@haojin2 haojin2 added the Numpy label Mar 25, 2020
@yijunc
Copy link
Contributor Author

yijunc commented Mar 26, 2020

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, unix-cpu, clang, unix-gpu, windows-cpu, edge, centos-cpu, miscellaneous, website, windows-gpu, sanity]

@haojin2
Copy link
Contributor

haojin2 commented Mar 31, 2020

@BenjaminCHEN2016 please remember to do git submodule update --init --recursive after you rebase to get rid of the change to 3rdparty/mkldnn

@yijunc yijunc requested a review from haojin2 March 31, 2020 08:39
@yijunc yijunc force-pushed the tril_indices branch 2 times, most recently from 10392a5 to 8951f28 Compare April 1, 2020 04:30
haojin2
haojin2 reviewed Apr 8, 2020
View reviewed changes
src/operator/numpy/np_matrix_op.cc Outdated
}

inline bool TrilindicesOpShape(const nnvm::NodeAttrs& attrs,
mxnet::ShapeVector* in_attrs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alignment

haojin2
haojin2 reviewed Apr 8, 2020
View reviewed changes
src/operator/numpy/np_matrix_op.cc Outdated
CHECK_EQ(out_attrs->size(), 2U);

const NumpyTrilindicesParam& param =
nnvm::get<NumpyTrilindicesParam>(attrs.parsed);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  const NumpyTrilindicesParam& param =
    nnvm::get<NumpyTrilindicesParam>(attrs.parsed);

haojin2
haojin2 reviewed Apr 8, 2020
View reviewed changes
src/operator/numpy/np_matrix_op-inl.h Outdated

template<typename xpu>
void TrilindicesOpForward(const nnvm::NodeAttrs& attrs,
const OpContext& ctx,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alignment

@yijunc
Copy link
Contributor Author

yijunc commented Apr 9, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@yijunc
Copy link
Contributor Author

yijunc commented Apr 9, 2020

@mxnet-bot run ci [macosx]

@mxnet-bot
Copy link

None of the jobs entered are supported.
Jobs entered by user: [macosx]
CI supported Jobs: [centos-gpu, miscellaneous, website, sanity, windows-cpu, windows-gpu, centos-cpu, unix-gpu, edge, clang, unix-cpu]

@yijunc
Copy link
Contributor Author

yijunc commented Apr 9, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@yijunc
Copy link
Contributor Author

yijunc commented Apr 10, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@haojin2 haojin2 merged commit af76466 into apache:master Apr 10, 2020
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
@yijunc @sxjscience
add: numpy op tril_indices (apache#17904)
673d3b3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@haojin2 haojin2 haojin2 left review comments

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

@haojin2 haojin2

Labels
Numpy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yijunc @mxnet-bot @haojin2