-
Notifications
You must be signed in to change notification settings - Fork 6.8k
CI: Attempt fixing illegal instruction errors #17842
Conversation
6282b89
to
f08991e
Compare
Caching the source-compiled variants via our Docker cache can lead to "Illegal instruction" errors when deploying the docker image on an older machines.
f08991e
to
157ca6b
Compare
Could you elaborate what that flag exactly does? |
Will this fix the issue #17840? |
@marcoabreu the flag disables AVX instruction set. https://github.com/facebook/zstd contains code that can be vectorized. For whatever reason, gcc uses avx instruction set even if it shouldn't (cf #14664) and we need to explicitly disable it as the resulting binary is used on different machines thanks to the docker cache. |
@apeforest I'm not sure about the TVM problem. I'm attempting to fix the following problem:
|
It's not really nice to merge a PR while there are still open questions.... Will this globally disable the AVX instruction set? |
@marcoabreu this fixes a bug in #17828 which you approved before. It's urgent as it blocks all CI runs. @apeforest approved this PR, which is why I merged the PR. |
Oh I didn't know it blocked. In that case, fine with me. Thanks for elaborating. Sounds good. |
…ache#17842)" This reverts commit bd6b80e.
Caching the source-compiled variants of libzstd1 and libb2 via our Docker cache can lead to "Illegal instruction" errors when deploying the docker image on an older machines.
Caching the source-compiled variants of libzstd1 and libb2 via our Docker cache can lead to "Illegal instruction" errors when deploying the docker image on an older machines.
Hypothesis: Caching the source-compiled variants of libzstd1 and libb2 via our Docker cache can lead to "Illegal instruction" errors when deploying the docker image on an older machines. If so, switching to the distribution provided variants will solve the issue.
Follow-up on #17828