Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[numpy][Do Not Review]add op insert #16865

Merged
merged 18 commits into from
Feb 15, 2020
Merged

[numpy][Do Not Review]add op insert #16865

merged 18 commits into from
Feb 15, 2020

Conversation

JiangZhaoh
Copy link
Contributor

Description

add op: insert
ONLY forward

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@JiangZhaoh JiangZhaoh requested a review from szha as a code owner November 20, 2019 05:59
@haojin2 haojin2 self-assigned this Nov 20, 2019
@haojin2 haojin2 requested review from haojin2 and reminisce November 20, 2019 08:13
@haojin2 haojin2 added the Numpy label Nov 20, 2019
@JiangZhaoh JiangZhaoh force-pushed the add_op_insert branch 2 times, most recently from fe16576 to 1a65793 Compare December 30, 2019 03:56
@JiangZhaoh JiangZhaoh changed the title [numpy]add op insert [numpy][Do Not Review]add op insert Feb 10, 2020
@JiangZhaoh JiangZhaoh force-pushed the add_op_insert branch 2 times, most recently from 88d653c to dcd55e0 Compare February 12, 2020 17:07
@JiangZhaoh
op : insert scalar
53c568b 
fix sanity error
@JiangZhaoh JiangZhaoh force-pushed the add_op_insert branch 2 times, most recently from 14ad567 to 258b77d Compare February 14, 2020 09:31
@JiangZhaoh
op : insert by slice
fd91dfd 
fix compile error

fix cmopile error again
@haojin2 haojin2 merged commit 149975c into apache:master Feb 15, 2020
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
@JiangZhaoh
[numpy][Do Not Review]add op insert (apache#16865)
a1c1529 
* add op insert

fix lint and compile error

fix pylint error

* fix slice bug

* modify code logic and patterns

fix sanity error

* reuse existing function / modify alignment

* support to insert a sigle number

* use range_fwd kernel

* reduce code

* fix a small mistake / remove redundant function

* reduce code again / resolove function conflict

* fix pylint error / decompose main function into small pieces

* test CI

* test CI 2

* test CI 3

* test CI 4

fix sanity error

* op : insert tensor

* op : insert scalar

fix sanity error

* op : insert by slice

fix compile error

fix cmopile error again

* fix code style problem
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
@JiangZhaoh @anirudh2290
[numpy][Do Not Review]add op insert (apache#16865)
12d6a99 
* add op insert

fix lint and compile error

fix pylint error

* fix slice bug

* modify code logic and patterns

fix sanity error

* reuse existing function / modify alignment

* support to insert a sigle number

* use range_fwd kernel

* reduce code

* fix a small mistake / remove redundant function

* reduce code again / resolove function conflict

* fix pylint error / decompose main function into small pieces

* test CI

* test CI 2

* test CI 3

* test CI 4

fix sanity error

* op : insert tensor

* op : insert scalar

fix sanity error

* op : insert by slice

fix compile error

fix cmopile error again

* fix code style problem
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hgt312 hgt312 hgt312 left review comments

@haojin2 haojin2 haojin2 left review comments

@szha szha Awaiting requested review from szha szha is a code owner

@reminisce reminisce Awaiting requested review from reminisce

Assignees

@haojin2 haojin2

Labels
Numpy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JiangZhaoh @haojin2 @hgt312