-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
@TaoLv could you give a simple summary of the reason for this change and any possible impacts? |
@pengzhao-intel , sure, PR description is added. |
@szha @lanking520 @perdasilva @marcoabreu Could you please review, especially the parts about CD and packaging? |
Very great explanation. Ping me when your PR is ready to merge. |
Wait for the internal testing results. Let's know if you have any comments or concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far. Let me know when you need the final review after it's no longer WIP
@szha @lanking520 @perdasilva @marcoabreu Call for review :) |
Have you tried?
|
@lanking520 Attached the build log. Please take a look. Thanks! |
Merging now |
Description
This PR intends to change MKL-DNN library from dynamic linking to static linking. That will help:
There were other attempts to do so before. But before MKL-DNN v1.0 integrated, it also depends on libmklml_intel.so. So it doesn't make much sense if we only make MKL-DNN static linked and leave libmklml_intel.so outside.
This PR is also removing a python unit test which was designed to check MKL-DNN install by doing grep against the proc maps to make sure mkldnn.so is linked. After changing to static link, the approach would not work and not needed.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments