fixing logic in USE_MKLDNN

[rsettlage]

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

• The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
• Changes are complete (i.e. I finished coding on this PR)
• All changes have test coverage:
• Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
• Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
• Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
• Code is well-documented:
• For user-facing API changes, API doc string has been updated.
• For new C++ functions in header files, their functionalities and arguments are documented.
• For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
• Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
• To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

• Feature1, tests, (and when applicable, API doc)
• Feature2, tests, (and when applicable, API doc)

Comments

• If this change is a backward incompatible change, why must this change be made.
• Interesting edge cases to note here

[anirudhacharya]

@mxnet-label-bot add [pr-awaiting-review]

[pengzhao-intel]

@rsettlage thanks for the improvement.
Could you check if this change is duplicated with previous one #14829?

[rsettlage]

Hi not duplicate, but the logic they have suggested will make this PR unnecessary. From: PatricZhao <[email protected]> Reply-To: apache/incubator-mxnet <[email protected]> Date: Saturday, May 4, 2019 at 6:44 AM To: apache/incubator-mxnet <[email protected]> Cc: Bob <[email protected]>, Mention <[email protected]> Subject: Re: [apache/incubator-mxnet] fixing logic in USE_MKLDNN (#14857) @rsettlage thanks for the improvement. Could you check if this change is duplicated with previous one #14829? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[karan6181]

@rsettlage Could you please provide an update on this PR? Does this change still require considering the #14829 ? Thanks!

[rsettlage]

I replied a long time ago. With the other PR, this will be redundant

…

Sent from my iPhone

On May 21, 2019, at 6:35 PM, Karan Jariwala ***@***.***> wrote: @rsettlage Could you please provide an update on this PR? Does this change still require considering the #14829 ? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[pengzhao-intel]

@rsettlage our PR is merged. Could you help verify if your problem is resolved?

[rsettlage]

Solved, thank you.

[pengzhao-intel]

Thanks, closing.