This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MXNET-1041] Add Java benchmark #13095
[MXNET-1041] Add Java benchmark #13095
Changes from 2 commits
20442c5
6edb645
96eea0e
08dc793
49fb918
b28b970
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm not sure whether or not we should add these to the public API for ObjectDetector. I made this mistake with loadImageFromFile earlier apparently because we don't yet have ImageClassifier in the Java API.
In the Scala version, the objectDetector benchmark and example call loadImageFromFile, reshapeImage, and bufferedImageToPixels directly from the ImageClassifier class. We're not able to do that from here yet but even if we could it seems odd to do so. Maybe we should move them to a utils class or something? What's everyone else think about how we should handle this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewfayres I am expecting this: https://github.com/apache/incubator-mxnet/blob/master/scala-package/core/src/main/scala/org/apache/mxnet/Image.scala would eventually help and replace the current JavaIO we have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is OK to keep this method since this class is anyway like a utility.