-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add docstring in im2rec.py #12621
Add docstring in im2rec.py #12621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the docstring. But why not include params and return details in the docstring?
(e.g. https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/autograd.py#L52)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
@aaronmarkham - Can you please take a look. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the one grammar change. Otherwise this is gtg!
tools/im2rec.py
Outdated
if line_len < 3: | ||
print('lst should at least has three parts, but only has %s parts for %s' %(line_len, line)) | ||
print('lst should at least has three parts, but only has %s parts for %s' % (line_len, line)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lst should have at least three parts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aaronmarkham
Description
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
N/A