[MXNET-627] Fix Installation instructions for R bindings on Linux systems. #11590
Conversation
docs/install/index.md
Outdated
| @@ -987,10 +987,23 @@ $ make -j $(nproc) USE_OPENCV=1 USE_BLAS=openblas | |||
|
|
|||
| **Build and install the MXNet R binding** | |||
|
|
|||
| You will need to first install R. MXNet requires R version >3.3 and we can fetch that from CRAN package repository. | |||
There was a problem hiding this comment.
Please add similar instructions for windows and os x users.
There was a problem hiding this comment.
for macOS and windows we do not build from source, this will not be there. There is only the issue of ensuring that the pre-built binary in the S3 works fine with both R 3.4 and 3.5.
And that is not part of this PR.
anirudhacharya
changed the title
|
Follow these directions to setup a test server and build the docs. Test the selector to make sure content shows up when you click on the different install options. |
|
@aaronmarkham It does show here correctly - http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-11590/3/index.html |
anirudhacharya
changed the title
|
So it looks like we have duplicated information on the install.md page and each of the $OS_setup.md pages. Also, when you use the install page's selector, you get instructions, but no link to the $OS_setup page. Wouldn't it be better to provide the minimum info needed on the install page, and leave the detail for the OS specific pages? |
|
@aaronmarkham you have been added as a collaborator to my repo. Please make the required changes and push to this branch. Thanks! |
|
I went ahead and resolved an issue with using the CI scripts as part of the installation instructions (@marcoabreu) for Ubuntu and made a new script for core and python deps. The "pre-pip" dependency install still uses the CI script though, since it doesn't do any source steps. (I suppose I can make another one for this or modify the install_mxnet_ubuntu_python.sh to have pip and source options.) I also made an R installation script (ported and updated the dmlc one to work with our install flow). The instructions are generally simplified now by having access to the two new shell scripts:
install_mxnet_ubuntu_python.sh
install_mxnet_ubuntu_r.sh
|
|
@hetong007 I updated the install page for OSX and Windows to point to the detailed instructions pages. OSX should be good to go now. Windows is being worked on in a separate PR by @ankkhedia. Please revisit your change request since further updates on Windows instructions is out of scope for this PR. |
docs/install/index.md
Outdated
|
|
||
| ```bash | ||
| $ cd incubator-mxnet/R-package |
There was a problem hiding this comment.
you run make rpkg from incubator-mxnet folder not incubator-mxnet/R-package
| @@ -20,17 +20,31 @@ | |||
| # build and install are separated so changes to build don't invalidate | |||
| # the whole docker cache for the image | |||
|
|
|||
| # Important Maintenance Instructions: | |||
There was a problem hiding this comment.
This is probably unintended, but the change to this file causes CI to occasionally fail. The keyserver for this gpg key fails approx 1/10 requests. Is there a good reason we reverted @larroy change which manually installs the key? It seemed like a reasonable fix for the flaky gpg server issue. Any objection to me restoring the manual key add?
…tems. (apache#11590) * fix doc * fix * fix * fix * gpu * nit * new ubuntu and r install scripts and docs; minor osx update * script now uses requirements.txt * removed unneeded commands * fixed path for make rpkg
Fix for #8240 #10147 #8869
Preview of the website - http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-11590/$BUILD_NUM/index.html
@hetong007 @aaronmarkham @ankkhedia