-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Would like to be able to execute build function several times, building ccache wrapers prevents this #14117
Comments
Hey, this is the MXNet Label Bot. |
Please provide more details around the current behaviour, the expected behaviour, how to observe/measure it and in how far the linked PR changed that. |
@mxnet-label-bot [ci] |
My data does not show any regressions as result of merging #13456 on 14th of December. |
It also prevents executing the build function two times. Why do we need to use these wrappers? Why not just using CC and CXX environment variables? jenkins_slave@013086bf91e1:/work/mxnet$ /work/runtime_functions.sh build_ubuntu_cpu
|
It is the recommended way to use ccache - as explained previously: https://ccache.samba.org/manual/latest.html#_run_modes |
Please feel free to submit a PR to make a conditional mkdir. |
It is required because underlying build-systems don't respect the wrapper methods. |
Ok maybe it's calling ccache but it's not obvious because of the wrappers, it's more obvious when the command includes ccache. Reproduction with:
I expect to be able to execute /work/runtime_functions.sh build_ubuntu_cpu several times. But seems ccache is in fact working. |
@marcoabreu there's two modes to run it according to the documentation: "There are two ways to use ccache. You can either prefix your compilation commands with ccache or you can let ccache masquerade as the compiler by creating a symbolic link (named as the compiler) to ccache. " |
In which case? which build system? |
We already had this discussion including all background details in #13456 |
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
@marcoabreu please list the submodules and dependencies which have these hardcoded paths, you didn't respond to the latest question by @roywei in the PR you linked ( #13456 ) I don't see we have a direct dependency on zeromq but only through a shell script. I don't think this is a valid reason to require root in all the build functions and override the compiler globally. I don't see any hardcoded path in PS-Lite, please add the data that you mention in the linked PR and avoid putting the burden of proof in contributors to the project or at least provide a path for proper fix. Could you also make this data about build time regressions publicly available or provide instructions to views it so other contributors can take it into consideration? |
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
* Fix broken links * Make it idempotent fixes apache#13456 fixes apache#14117 fixes apache#11516
Description
See comments below. Ccache is in fact working on cpu openblas builds, hence the change of title.
@marcoabreu
Environment info (Required)
Build info (Required if built from source)
Compiler (gcc/clang/mingw/visual studio):
MXNet commit hash:
0a2419f
Minimum reproducible example
The text was updated successfully, but these errors were encountered: