GH-268: Fix ClientConnectionService.sendHeartBeat() #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a reply is requested, but none arrives within the timeout, throw an exception and terminate the connection. This rolls back the changes made in ClientConnectionService in commit de2f8fe. It's quite all right to use the synchronous implementation of Session.request() because heartbeats are not sent from I/O threads. However, commit de2f8fe broke the contract specified in interface Session, which says Session.request() must return "the buffer if the request was successful, {@code null} otherwise." The implementation from commit de2f8fe threw an exception instead. This was wrong, and is corrected now in this commit. Note that this means that a caller cannot distinguish between the server replying SSH_MSG_UNIMPLEMENTED or SSH_MSG_REQUEST_FAILURE. Where such distinction is needed, use an asynchronous global request instead. Bug: apache#268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a reply is requested, but none arrives within the timeout, throw an
exception and terminate the connection.
This rolls back the changes made in ClientConnectionService in commit
de2f8fe. It's quite all right to use the synchronous implementation of
Session.request() because heartbeats are not sent from I/O threads.
However, commit de2f8fe broke the contract specified in interface
Session, which says Session.request() must return "the buffer if the
request was successful,
nullotherwise." The implementation fromcommit de2f8fe threw an exception instead.
This was wrong, and is corrected now in this commit. Note that this
means that a caller cannot distinguish between the server replying
SSH_MSG_UNIMPLEMENTED or SSH_MSG_REQUEST_FAILURE.
Where such distinction is needed, use an asynchronous global request
instead.
Fixes #268.