Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Define all MANIFEST.MF entries through the bnd-maven-plugin #518

Conversation

HannesWell
Copy link
Contributor

@HannesWell HannesWell commented Jun 21, 2024

Define all MANIFEST.MF entries through the bnd-maven-plugin and derive Bundle-SymbolicName header from the artifactId.

This changes the 'Bundle-SymbolicName' and 'Automatic-Module-Name' for the following modules:

  • maven-resolver-named-locks from org.apache.maven.resolver.named to org.apache.maven.resolver.named.locks
  • maven-resolver-test-util from org.apache.maven.resolver.testutil to org.apache.maven.resolver.test.util

This is effectively the back-port of #517 to the maven-resolver-1.9.x branch.
The main difference is that unlike in #517, this change does not 'prepare' the introduction of JPMS module-info.java/class files.

and derive 'Bundle-SymbolicName' header from the artifactId.

This changes the 'Bundle-SymbolicName' and 'Automatic-Module-Name' for
the following modules:
- maven-resolver-named-locks
	from 'org.apache.maven.resolver.named'
	to 'org.apache.maven.resolver.named.locks'
- maven-resolver-test-util
	from 'org.apache.maven.resolver.testutil'
	to 'org.apache.maven.resolver.test.util'
@HannesWell
Copy link
Contributor Author

@gnodet or @cstamas could you please have a look at this as well?

@HannesWell
Copy link
Contributor Author

@gnodet now that #517 is submitted for master, can we have this for resolver-1.9.x?

@gnodet gnodet merged commit 52b4db3 into apache:maven-resolver-1.9.x Jun 25, 2024
11 checks passed
@HannesWell HannesWell deleted the resolver-1.9.x-unify-all-manifest-headers branch June 26, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants