Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept all line endings with spotless #217

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

kwin
Copy link
Member

@kwin kwin commented Dec 6, 2024

Accept all line endings (even outside git repositories), compare with diffplug/spotless#2277
This closes #205

Accept all line endings (even outside git repositories), compare with
diffplug/spotless#2277
This closes #205
@kwin kwin requested a review from gnodet December 6, 2024 15:16
@kwin
Copy link
Member Author

kwin commented Dec 6, 2024

Overlaps with #213

@gnodet gnodet added this to the MAVEN-44 milestone Dec 6, 2024
@gnodet
Copy link
Contributor

gnodet commented Dec 6, 2024

Could you rename when merging to point out the fix for line endings, as the spotless upgrade is just the mean to that end.

@kwin kwin merged commit c8d88ef into master Dec 7, 2024
10 checks passed
@kwin kwin deleted the feature/spotless2.44-accepting-all-line-ending branch December 7, 2024 15:53
@slawekjaranowski
Copy link
Member

@kwin please look at release notes .... summary of PR should be similar to commit

@kwin kwin changed the title Update to spotless-m-p 2.44.0.BETA4 Accept all line endings with spotless Dec 8, 2024
@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails on source-release.zip created on another platform
3 participants