Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSKINS-185] Don't fall back anymore if bannerLeft ist not provided #27

Merged
merged 1 commit into from
May 10, 2022

Conversation

michael-o
Copy link
Member

…ault

asfgit pushed a commit that referenced this pull request May 8, 2022
@asfgit asfgit force-pushed the clean-up-banner-handling branch from ec3ea2e to adc3774 Compare May 8, 2022 13:21
@michael-o michael-o changed the title Use <h1/> and rely on Doxia Sitetools to provide a left banner by def… [MSKINS-185] Don't fall back anymore if bannerLeft ist not provided May 8, 2022
@michael-o michael-o marked this pull request as ready for review May 8, 2022 13:21
@michael-o michael-o requested a review from hboutemy May 8, 2022 13:22
@michael-o
Copy link
Member Author

@kwin Have a look...

Copy link
Member

@kwin kwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit force-pushed the clean-up-banner-handling branch from adc3774 to f73171b Compare May 10, 2022 16:47
@asfgit asfgit merged commit f73171b into master May 10, 2022
@michael-o michael-o deleted the clean-up-banner-handling branch May 10, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants