[MENFORCER-431] Introduce option to skip specific rules via custom property #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiroky
commented
Dec 27, 2022
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java
Outdated
Show resolved
Hide resolved
psiroky
commented
Dec 27, 2022
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java
Outdated
Show resolved
Hide resolved
psiroky
commented
Dec 27, 2022
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java
Outdated
Show resolved
Hide resolved
psiroky
commented
Dec 27, 2022
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java
Show resolved
Hide resolved
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java
Show resolved
Hide resolved
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java
Outdated
Show resolved
Hide resolved
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java
Outdated
Show resolved
Hide resolved
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| invoker.goals = validate -Denforcer.skipRules=alwaysFail |
There was a problem hiding this comment.
- please add verify script yo be sure that rule
alwaysPasswas executed
|
@slawekjaranowski thanks for the heads-up. That seems to change things quite a bit, so I will probably wait until it gets merged and then re-do my changes on top of that. |
psiroky
force-pushed
the
MENFORCER-431
branch
from
5b19721 to
e6d96a8
Compare
psiroky
changed the title
|
@slawekjaranowski I believe this should be now ready for review. Please take another look when you get a chance. |
slawekjaranowski
approved these changes
Dec 29, 2022
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am creating this draft PR to discuss couple of points. This is not yet ready to merge. See the inline comments.
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MENFORCER-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.