[MENFORCER-398] show rules processed #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -187,7 +187,7 @@ public void execute() | |||
| // store the current rule for | |||
| // logging purposes | |||
| currentRule = rule.getClass().getName(); | |||
| log.debug( "Executing rule: " + currentRule ); | |||
| log.info( "Executing rule: " + currentRule ); | |||
There was a problem hiding this comment.
Rule is executed in line 199, we will have such message even when rule will not be executed in case of cache.
Is it what we want?
|
Please also put issue number in square brackets in commit message and PR title |
raupachz
changed the title
|
Thanks for the feedback @slawekjaranowski ! I updated the pull request accordingly.
|
|
@raupachz thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
this fixes MENFORCER-398. It is a simple one line change. Turning on DEBUG already logs what rules are processed. Since most people probably run Maven in default settings they won't see the rules processed. Changing the log level from DEBUG to INFO allows everyone to see the rule processed.
This is an up-for-grabs issue. Feedback welcome.
Make sure there is a JIRA issue filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like
[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MENFORCER-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
You have run the integration tests successfully (
mvn -Prun-its clean verify).I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004