Skip to content

Commit

Permalink
chore: exclude changes related to reporting-only mode
Browse files Browse the repository at this point in the history
  • Loading branch information
alexey-anufriev committed Mar 6, 2023
1 parent 5075b26 commit 9074b21
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@
@Named("dependencyConvergence")
public final class DependencyConvergence extends AbstractStandardEnforcerRule {

private boolean fail = true;

private boolean uniqueVersions;

private List<String> includes;
Expand Down Expand Up @@ -96,7 +94,7 @@ public DependencySelector deriveChildSelector(DependencyCollectionContext contex
for (CharSequence errorMsg : errorMsgs) {
getLog().warnOrError(errorMsg);
}
if (fail && errorMsgs.size() > 0) {
if (errorMsgs.size() > 0) {
throw new EnforcerRuleException(
"Failed while enforcing releasability. " + "See above detailed error message.");
}
Expand Down
13 changes: 0 additions & 13 deletions enforcer-rules/src/site/apt/dependencyConvergence.apt.vm
Original file line number Diff line number Diff line change
Expand Up @@ -164,16 +164,3 @@ and
</excludes>
</dependencyConvergence>
+---------------------------------------------

* Reporting Only Mode

By default, when convergence error is detected the build will fail.
If you want to have only reporting, without errors in the build, then <<<fail>>> property must be set to <<<false>>>.

+---------------------------------------------
<dependencyConvergence>
<fail>false</fail>
</dependencyConvergence>
+---------------------------------------------

Not specifying this property will cause the build to fail in case of any convergence errors.

0 comments on commit 9074b21

Please sign in to comment.