Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Entrance] Remove redundant code #5144

Merged
merged 1 commit into from
Jul 14, 2024
Merged

[Entrance] Remove redundant code #5144

merged 1 commit into from
Jul 14, 2024

Conversation

guoshupei
Copy link
Collaborator

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@guoshupei guoshupei changed the title Remove redundant code [Entrance] Remove redundant code Jul 11, 2024
@guoshupei
Copy link
Collaborator Author

@peacewong Help me rerun again

@peacewong
Copy link
Contributor

@peacewong Help me rerun again

ok Thanks！

peacewong
peacewong approved these changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 273394f into apache:master Jul 14, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peacewong peacewong peacewong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guoshupei @peacewong