-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scala version suffix on scala modules #888
Conversation
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
============================================
+ Coverage 78.79% 79.14% +0.35%
Complexity 11 11
============================================
Files 137 143 +6
Lines 5196 5346 +150
Branches 644 649 +5
============================================
+ Hits 4094 4231 +137
- Misses 749 752 +3
- Partials 353 363 +10
Continue to review full report at Codecov.
|
cc @ulysses-you after this PR, Because we are not intended to support multi scala version in short term, e.g. 2.13, just hardcode |
thanks, merging to master for v1.3.0 |
Why are the changes needed?
kyuubi-extension-spark-3-1
in daily publish snapshotHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request