Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scala version suffix on scala modules #888

Closed
wants to merge 8 commits into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Aug 3, 2021

Why are the changes needed?

  • Add scala version suffix on scala modules to match the name pattern.
  • Enable kyuubi-extension-spark-3-1 in daily publish snapshot

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #888 (6090c79) into master (962d721) will increase coverage by 0.35%.
The diff coverage is 100.00%.

❗ Current head 6090c79 differs from pull request most recent head 571eb9c. Consider uploading reports for the commit 571eb9c to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #888      +/-   ##
============================================
+ Coverage     78.79%   79.14%   +0.35%     
  Complexity       11       11              
============================================
  Files           137      143       +6     
  Lines          5196     5346     +150     
  Branches        644      649       +5     
============================================
+ Hits           4094     4231     +137     
- Misses          749      752       +3     
- Partials        353      363      +10     
Impacted Files Coverage Δ
...ache/kyuubi/engine/spark/SparkProcessBuilder.scala 90.00% <100.00%> (ø)
.../scala/org/apache/kyuubi/server/KyuubiServer.scala 47.36% <0.00%> (-2.64%) ⬇️
...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala 79.41% <0.00%> (-0.99%) ⬇️
...ache/kyuubi/engine/spark/events/JsonProtocol.scala 100.00% <0.00%> (ø)
...e/kyuubi/engine/spark/events/JsonEventLogger.scala 90.00% <0.00%> (ø)
...e/kyuubi/engine/spark/events/EventLoggerType.scala 100.00% <0.00%> (ø)
...uubi/engine/spark/events/EventLoggingService.scala 82.60% <0.00%> (ø)
...a/org/apache/spark/kyuubi/SparkContextHelper.scala 100.00% <0.00%> (ø)
...pache/kyuubi/engine/spark/events/EngineEvent.scala 90.00% <0.00%> (ø)
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 94.41% <0.00%> (+0.26%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 962d721...571eb9c. Read the comment docs.

@pan3793
Copy link
Member Author

pan3793 commented Aug 3, 2021

cc @ulysses-you after this PR, kyuubi-extension-spark-3-1-1.3.0.jar will change to kyuubi-extension-spark-3-1_2.12-1.3.0.jar.

Because we are not intended to support multi scala version in short term, e.g. 2.13, just hardcode _2.12 in some place.

@ulysses-you
Copy link
Contributor

thanks, merging to master for v1.3.0

@pan3793 pan3793 self-assigned this Aug 4, 2021
@pan3793 pan3793 added the infra label Aug 4, 2021
@pan3793 pan3793 added this to the v1.3.0 milestone Aug 4, 2021
@pan3793 pan3793 deleted the scala branch August 4, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants