Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Refine monitoring docs #6938

Closed
wants to merge 1 commit into from

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented Feb 23, 2025

Why are the changes needed?

The PR is needed to make monitoring docs more clear and aligned with General Style:

  • Used unordered list instead of ordered (similar to other menus)
  • Deleted empty events.md page
  • Pages renamed to shorter versions
  • Fixed Trouble Shooting typo

How was this patch tested?

Tested by building documentation locally.

Before changes
image

After changes
image

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the kind:documentation Documentation is a feature! label Feb 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (0f4906d) to head (7ac8dcb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6938   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         689     689           
  Lines       42615   42615           
  Branches     5808    5808           
======================================
  Misses      42615   42615           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pan3793 pan3793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change lgtm, please run dev/reformat to fix the style

@dnskr dnskr force-pushed the refine-monitoring-docs branch from f472ed2 to 7ac8dcb Compare February 24, 2025 18:59
@pan3793 pan3793 added this to the v1.11.0 milestone Feb 25, 2025
@pan3793
Copy link
Member

pan3793 commented Feb 25, 2025

Thanks, merged to master

@pan3793 pan3793 closed this in d33aa0b Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation Documentation is a feature!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants