Fix get existing gauge issue #6891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
force-pushed
the
gauge_exists
branch
from
15a5493 to
039e7b5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6891 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 688 688
Lines 42590 42590
Branches 5805 5805
======================================
Misses 42590 42590 ☔ View full report in Codecov by Sentry. |
pan3793
reviewed
Jan 21, 2025
kyuubi-metrics/src/main/scala/org/apache/kyuubi/metrics/MetricsSystem.scala
Outdated
Show resolved
Hide resolved
|
this looks like an independent issue, though it affects #6866, please update the title with a new ticket id or leave it to let the merge script to assign automatically. |
turboFei
changed the title
done |
pan3793
approved these changes
Jan 22, 2025
turboFei
added a commit
that referenced
this pull request
Jan 23, 2025
### Why are the changes needed?
For the `com.codahale.metrics.MetricRegistry::gauge`.
It `getOrAdd` the gauge with name.
```
public <T extends Gauge> T gauge(String name) {
return (Gauge)this.getOrAdd(name, MetricRegistry.MetricBuilder.GAUGES);
}
```
So we have to get all the gauges to check whether the gauge exists.
### How was this patch tested?
UT.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #6891 from turboFei/gauge_exists.
Closes #6891
18be2a5 [Wang, Fei] o(1)
039e7b5 [Wang, Fei] check existing gauge
32dce6f [Wang, Fei] check gauge exists
Authored-by: Wang, Fei <[email protected]>
Signed-off-by: Wang, Fei <[email protected]>
(cherry picked from commit e12d1ff)
Signed-off-by: Wang, Fei <[email protected]>
|
thanks, merged to master and 1.10.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
For the
com.codahale.metrics.MetricRegistry::gauge.It
getOrAddthe gauge with name.So we have to get all the gauges to check whether the gauge exists.
How was this patch tested?
UT.
Was this patch authored or co-authored using generative AI tooling?
No.