Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GA] Enable Kyuubi nightly build against Spark master #654

Closed
wants to merge 2 commits into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented May 31, 2021

Why are the changes needed?

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request


on:
schedule:
- cron: 0 23 * * *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the time for spark nightly build?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

midnight, and should we change it to 1:00 am?

Copy link
Member Author

@pan3793 pan3793 May 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have look on Spark GA history list, nightly build usually cost 1~2 hours, and sometime over 3 hours, maybe we should start at 4:00 am.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #654 (eef7ed5) into master (2e21f08) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head eef7ed5 differs from pull request most recent head c851140. Consider uploading reports for the commit c851140 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
- Coverage   80.07%   80.03%   -0.05%     
==========================================
  Files         120      120              
  Lines        4693     4693              
  Branches      568      568              
==========================================
- Hits         3758     3756       -2     
- Misses        609      612       +3     
+ Partials      326      325       -1     
Impacted Files Coverage Δ
.../org/apache/kyuubi/operation/KyuubiOperation.scala 57.57% <0.00%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e21f08...c851140. Read the comment docs.

@yaooqinn
Copy link
Member

yaooqinn commented Jun 1, 2021

will merge this affer 6:00 pm, Asia/Shanghai

@yaooqinn yaooqinn closed this in c52b953 Jun 1, 2021
@yaooqinn yaooqinn added the Test label Jun 1, 2021
@yaooqinn yaooqinn added this to the v1.3.0 milestone Jun 1, 2021
@yaooqinn
Copy link
Member

yaooqinn commented Jun 1, 2021

thanks, merged to master for v1.3.0

@pan3793 pan3793 deleted the ga branch June 1, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants