-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GA] Enable Kyuubi nightly build against Spark master #654
Conversation
.github/workflows/nightly.yml
Outdated
|
||
on: | ||
schedule: | ||
- cron: 0 23 * * * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the time for spark nightly build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
midnight, and should we change it to 1:00 am?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have look on Spark GA history list, nightly build usually cost 1~2 hours, and sometime over 3 hours, maybe we should start at 4:00 am.
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
- Coverage 80.07% 80.03% -0.05%
==========================================
Files 120 120
Lines 4693 4693
Branches 568 568
==========================================
- Hits 3758 3756 -2
- Misses 609 612 +3
+ Partials 326 325 -1
Continue to review full report at Codecov.
|
will merge this affer 6:00 pm, Asia/Shanghai |
thanks, merged to master for v1.3.0 |
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request