Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6250][FOLLOWUP] Simplify code after dropping Spark 3.1 #6277

Closed
wants to merge 1 commit into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Apr 9, 2024

🔍 Description

As title, simplify code after dropping Spark 3.1.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Pass GHA.


Checklist 📝

Be nice. Be informative.

@pan3793
Copy link
Member Author

pan3793 commented Apr 9, 2024

cc @liuxiaocs7

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 58.36%. Comparing base (42c619a) to head (2b52de6).
Report is 1 commits behind head on master.

Files Patch % Lines
...ache/kyuubi/engine/spark/schema/SchemaHelper.scala 57.14% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6277      +/-   ##
============================================
- Coverage     58.47%   58.36%   -0.11%     
  Complexity       24       24              
============================================
  Files           651      650       -1     
  Lines         39550    39543       -7     
  Branches       5449     5448       -1     
============================================
- Hits          23125    23081      -44     
- Misses        13952    13979      +27     
- Partials       2473     2483      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@liuxiaocs7 liuxiaocs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the reminder

@pan3793 pan3793 self-assigned this Apr 9, 2024
@pan3793 pan3793 added this to the v1.10.0 milestone Apr 9, 2024
@pan3793 pan3793 closed this in 563d005 Apr 9, 2024
@pan3793
Copy link
Member Author

pan3793 commented Apr 9, 2024

Merged to master

@pan3793 pan3793 deleted the 6273-followup branch June 6, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants