-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #5952] Disconnect connections without running operations after engine maxlife time graceful period #5950
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5950 +/- ##
============================================
+ Coverage 61.20% 61.21% +0.01%
Complexity 23 23
============================================
Files 622 622
Lines 36897 36899 +2
Branches 5016 5017 +1
============================================
+ Hits 22582 22589 +7
+ Misses 11875 11868 -7
- Partials 2440 2442 +2 ☔ View full report in Codecov by Sentry. |
fa2fe08
to
fe46552
Compare
#2250 has been released for a while, I recommend using a new issue id to track the issue. |
Not sure why EtcdConnectionLevelSparkEngineSuite always fail, cc @hddong is there any special for ETCD? |
1e38113
to
bd18a38
Compare
Shall we reject new operations after the engine has stopped gracefully? That way the connection will be closed after session idle timeout. |
It is difficult to implement in code. Some rpc does not create operation but will update the session last access time with |
@turboFei the jetcd upgrade involves gRPC upgrading, I have done it on master, please revert your latest commit and rebase master to see if helps |
ut ut revert save save debug Revert "debug" This reverts commit fe46552. retry
e34f801
to
0352dd1
Compare
raised #6020 |
🔍 Description
Issue References 🔗
We found that, some kyuubi connections(maybe managed by jdbc connection pool likes hikari) always keep alive, and the engine can not be terminated after exceeds the max life time.
So, In this pr, I introduce a graceful period after spark engine max life time, after the graceful period, the connections without running operations will be disconnected forcibly.
Close #5952
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.