Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Install and cache build/mvn in CI builds #4747

Closed
wants to merge 2 commits into from

Conversation

bowenliang123
Copy link
Contributor

Why are the changes needed?

  • introduce a custom action for installing and caching Maven, to prevent repeatedly downloading Maven binary from remote.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@github-actions github-actions bot added the kind:infra license, community building, project builds, asf infra related, etc. label Apr 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Merging #4747 (bbd9e1f) into master (6876f82) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4747      +/-   ##
============================================
- Coverage     58.07%   58.06%   -0.02%     
  Complexity       13       13              
============================================
  Files           581      581              
  Lines         32323    32325       +2     
  Branches       4314     4308       -6     
============================================
- Hits          18772    18768       -4     
- Misses        11753    11754       +1     
- Partials       1798     1803       +5     

see 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bowenliang123 bowenliang123 marked this pull request as ready for review April 21, 2023 11:55
@bowenliang123 bowenliang123 requested a review from pan3793 April 21, 2023 11:55
@pan3793 pan3793 added this to the v1.8.0 milestone Apr 23, 2023
@pan3793
Copy link
Member

pan3793 commented Apr 23, 2023

Thanks, merged to master

@pan3793 pan3793 closed this in 83c4bed Apr 23, 2023
@bowenliang123 bowenliang123 deleted the cache-maven branch April 24, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:infra license, community building, project builds, asf infra related, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants