Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup and use cached maven in CI jobs #4481

Closed
wants to merge 2 commits into from

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Mar 8, 2023

Why are the changes needed?

  • Setup and use cached build/mvn in CI jobs, to prevent repeatedly downloading mvn from remote

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@github-actions github-actions bot added the kind:infra license, community building, project builds, asf infra related, etc. label Mar 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4481 (3668062) into master (222a334) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4481      +/-   ##
============================================
- Coverage     53.32%   53.31%   -0.02%     
  Complexity       13       13              
============================================
  Files           571      571              
  Lines         31249    31252       +3     
  Branches       4214     4215       +1     
============================================
- Hits          16663    16661       -2     
- Misses        13011    13015       +4     
- Partials       1575     1576       +1     
Impacted Files Coverage Δ
...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala 59.09% <0.00%> (-7.58%) ⬇️
...g/apache/kyuubi/operation/BatchJobSubmission.scala 75.27% <0.00%> (-2.20%) ⬇️
...mon/src/main/scala/org/apache/kyuubi/Logging.scala 41.25% <0.00%> (-1.25%) ⬇️
...rc/main/scala/org/apache/spark/ui/EnginePage.scala 79.43% <0.00%> (+0.28%) ⬆️
...in/lineage/helper/SparkSQLLineageParseHelper.scala 63.05% <0.00%> (+0.41%) ⬆️
...in/spark/authz/ranger/SparkRangerAdminPlugin.scala 67.10% <0.00%> (+2.63%) ⬆️
...uubi/engine/spark/events/SparkOperationEvent.scala 94.44% <0.00%> (+5.55%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bowenliang123 bowenliang123 requested a review from pan3793 March 8, 2023 12:38
@bowenliang123 bowenliang123 self-assigned this Mar 8, 2023
@bowenliang123 bowenliang123 added this to the v1.8.0 milestone Mar 8, 2023
@bowenliang123 bowenliang123 deleted the setup-maven branch March 8, 2023 14:36
@bowenliang123
Copy link
Contributor Author

Thanks, merged to master.

pan3793 added a commit that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:infra license, community building, project builds, asf infra related, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants