Flink SQL Engine - GetColumns Operation #3519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix
|
Codecov Report
@@ Coverage Diff @@
## master #3519 +/- ##
============================================
- Coverage 51.72% 51.70% -0.02%
Complexity 13 13
============================================
Files 482 482
Lines 26933 26950 +17
Branches 3760 3761 +1
============================================
+ Hits 13930 13934 +4
- Misses 11652 11657 +5
- Partials 1351 1359 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
reviewed
Sep 19, 2022
...bi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/GetColumns.scala
Show resolved
Hide resolved
pan3793
reviewed
Sep 23, 2022
...bi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/GetColumns.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Sep 23, 2022
...bi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/GetColumns.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Sep 23, 2022
pan3793
approved these changes
Sep 26, 2022
SteNicholas
reviewed
Sep 26, 2022
...bi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/GetColumns.scala
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Sep 26, 2022
There was a problem hiding this comment.
Thanks for @cxzl25 contribution. I have left the minor comment for this pull request. PTAL.
3 tasks
SteNicholas
approved these changes
Sep 28, 2022
|
Thanks, merging to master/1.6 |
pan3793
pushed a commit
that referenced
this pull request
Sep 28, 2022
### _Why are the changes needed?_ #1322 #2129 ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #3519 from cxzl25/flink_get_columns. Closes #3519 ab81776 [sychen] add column size efdf1b9 [sychen] indent 630e907 [sychen] refactor 48a79d5 [sychen] add ut 69763bd [sychen] GetColumns 8e5e6c5 [sychen] GetColumns Authored-by: sychen <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 8419b7b) Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
#1322
#2129
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request