Fix GetTables operation in Flink #3498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix
|
pan3793
reviewed
Sep 16, 2022
...ubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/GetTables.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Sep 16, 2022
pan3793
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3498 +/- ##
============================================
- Coverage 51.65% 51.64% -0.02%
Complexity 13 13
============================================
Files 482 482
Lines 26933 26933
Branches 3760 3760
============================================
- Hits 13913 13910 -3
- Misses 11663 11664 +1
- Partials 1357 1359 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks, merging to master/1.6 |
pan3793
pushed a commit
that referenced
this pull request
Sep 17, 2022
### _Why are the changes needed?_ #1646 In Flink, the schema returned by `GetTables` is incorrect, causing some database management tools to not see the table. ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #3498 from cxzl25/flink_get_tables. Closes #3498 6e51487 [sychen] compile cba0613 [sychen] toArray 37bd6aa [sychen] style 93fb80c [sychen] GetTables Authored-by: sychen <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit dce40c3) Signed-off-by: Cheng Pan <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
#1646
In Flink, the schema returned by
GetTablesis incorrect, causing some database management tools to not see the table.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request