[KYUUBI#2405] Support Flink StringData Data Type #2718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @link3280, could you please add the FLINK JIRA ticket link about the change you described? |
pan3793
reviewed
May 22, 2022
...ls/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/schema/RowSet.scala
Outdated
Show resolved
Hide resolved
|
@pan3793 Sure. Updated. |
…/org/apache/kyuubi/engine/flink/schema/RowSet.scala Co-authored-by: Cheng Pan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2718 +/- ##
============================================
- Coverage 64.82% 61.92% -2.90%
+ Complexity 279 238 -41
============================================
Files 409 406 -3
Lines 19661 19603 -58
Branches 2638 2632 -6
============================================
- Hits 12745 12140 -605
- Misses 5706 6298 +592
+ Partials 1210 1165 -45
Continue to review full report at Codecov.
|
yanghua
reviewed
May 22, 2022
...ls/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/schema/RowSet.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
May 23, 2022
|
Thanks, merging to master |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Currently, Flink uses its legacy data type system in CollectSink, but sooner would move to the new type system (see https://issues.apache.org/jira/browse/FLINK-12251). Kyuubi should adapt to the new data type system beforehand.
This PR supports StringData in Flink.
This is a subtask of #2100 .
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request