Improve CI with cancel & concurrency & paths filter #2175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
kind:infra
yaooqinn
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2175 +/- ##
============================================
- Coverage 61.50% 61.45% -0.05%
+ Complexity 124 69 -55
============================================
Files 325 327 +2
Lines 15598 15659 +61
Branches 1999 2005 +6
============================================
+ Hits 9593 9624 +31
- Misses 5190 5214 +24
- Partials 815 821 +6
Continue to review full report at Codecov.
|
|
cc @pan3793 @ulysses-you @turboFei @SteNicholas @hddong thanks. |
pan3793
approved these changes
Mar 19, 2022
pan3793
reviewed
Mar 19, 2022
.github/workflows/style.yml
Outdated
| # Well, sometimes when we introduce a new module, it may 'fail' the style check for missing | ||
| # dependency we just create for other module to inherit. | ||
| # We can ignore this failure and merge the PR, if we see the style check pass on the new module | ||
| # or via a local quick verification. |
yaooqinn
commented
Mar 19, 2022
yaooqinn
commented
Mar 19, 2022
|
thanks, merged to master |
3 tasks
pan3793
added a commit
that referenced
this pull request
Feb 9, 2023
### _Why are the changes needed?_ Since #2175, the previous running CI jobs will be canceled on the same branch or PR to save CI resources, this PR keeps the behavior for PR but doesn't cancel the running CI jobs when commit to the stable branch. Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-a-fallback-value ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate I pushed an empty commit to verify the behavior does not change in PR, and I need to merge this to master first, then merge another PR immediately to verify the rest behaviors. - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4285 from pan3793/ci-con. Closes #4285 3aa7f42 [Cheng Pan] empty 4156eb1 [Cheng Pan] Do not cancel CI jobs on stable branch Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Better ASF GHA resource usage, see more https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Canceled: https://github.com/apache/incubator-kyuubi/runs/5604809742?check_suite_focus=true