Revamp Github Action settings for CI #1947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1947 +/- ##
============================================
- Coverage 60.89% 60.86% -0.04%
Complexity 69 69
============================================
Files 302 302
Lines 14785 14797 +12
Branches 1914 1915 +1
============================================
+ Hits 9004 9006 +2
- Misses 5011 5022 +11
+ Partials 770 769 -1
Continue to review full report at Codecov.
|
ulysses-you
reviewed
Feb 22, 2022
| restore-keys: | | ||
| ${{ runner.os }}-maven-io- | ||
| - name: Build with Maven | ||
| cache: 'maven' |
There was a problem hiding this comment.
this is a good code improvement ! more details action docs
There was a problem hiding this comment.
Awosome, do we need to un-pin actions/[email protected]?
ulysses-you
approved these changes
Feb 22, 2022
pan3793
approved these changes
Feb 22, 2022
pan3793
reviewed
Feb 22, 2022
pan3793
reviewed
Feb 22, 2022
pan3793
reviewed
Feb 22, 2022
3 tasks
cfmcgrady
reviewed
Feb 22, 2022
|
thanks @pan3793 @ulysses-you @cfmcgrady for the help, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
includeactions/cache@v2withactions/setup-java@v2-cache: 'maven'How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Need to pass all CI jobs